Add retry to net.LookupHost() in nodeadm#2585
Merged
mselim00 merged 6 commits intoawslabs:mainfrom Jan 19, 2026
Merged
Conversation
mselim00
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Our team runs continuous integration tests on Outpost nodes. We noticed that from time to time, nodes fail
nodeadm-configservice with the following error:Upon examining the code, I found out that the error comes from
net.LookupHost(). During node bootstrap, there is nondeterministic amount of time that takes the networking to become ready betweennodeadm-boot-hook.servicereconfigures it andnodeadm-run.servicecallingnet.LookupHost().I examined log timings for nodes that failed and succeeded and in both cases
nodeadm-config.servicestarts afternodeadm-boot-hook.service. However in some cases the bootstrap fails because network setup takes a bit longer:Hence I decided to introduce some retries in
nodeadm.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
I manually built the AMI and was able to join node to my cluster:
I also tested the retrying logic, by passing a broken API URL:
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.